dsrkafuu / skyline-overlay

A modern customizable horizon FFXIV miniparse overlay. | 现代定制化 FF14 水平悬浮窗模板。
https://skyline.dsrkafuu.net
Apache License 2.0
79 stars 10 forks source link

Clicking on a text input field freezes the overlay #16

Closed Jessidhia closed 2 years ago

Jessidhia commented 2 years ago

Describe the bug When you click on a text input field (tested "Pet Merging ID", "Custom ID"), the entire overlay freezes and stops responding to any input.

To Reproduce Steps to reproduce the behavior:

  1. Click ⚙️ icon
  2. Go to Display tab
  3. Click on the "Custom ID" field (default value "YOU")
  4. Everything freezes

Expected behavior Text to be editable

Additional context When this happens, most of the controls in the OverlayPlugin work either. Toggling "Force white background" does nothing, as does clicking "Reload overlay"; but toggling "Enable overlay" off and on again does reload the overlay. The likely reason is an infinite loop in the javascript that locks the UI thread.

dsrkafuu commented 2 years ago

20211205105924

Unable to reproduce the problem with ACT 3.5.0.273 and OverlayPlugin 0.17.2.

Theoretically, clicking on the input box in the Overlay window will bring up a prompt dialog, which is to prevent the problem of not being able to enter text properly in the game.

Can you open the Debug Tool (Chrome Dev Tool) in the OverlayPlugin to see if there is any output from the console?

Jessidhia commented 2 years ago

The Debug Tool itself also freezes when I attempt to open it. Not even the DOM inspector works once it has entered the frozen state...

Although, once I updated the FFXIV plugin beta once more and restarted ACT, the prompt seems to be working again. Very strange 😥