dsrkafuu / skyline-overlay

A modern customizable horizon FFXIV miniparse overlay. | 现代定制化 FF14 水平悬浮窗模板。
https://skyline.dsrkafuu.net
Apache License 2.0
79 stars 10 forks source link

Players per row feature #33

Closed JamesAndrewsXV closed 1 year ago

JamesAndrewsXV commented 2 years ago

Add a players per row feature such that when a player count exceeds the row limit, it starts a new one.

Alternatively, set a row and column limit or even a hard coded 4x2 version of the meter.

dsrkafuu commented 2 years ago

Working on this soon, there should be a "vertical limit" as we currently only have a "horizontal limit".

JamesAndrewsXV commented 2 years ago

Great to hear! This would be my favorite feature by far, love everything else about this overlay.

JamesAndrewsXV commented 1 year ago

Hey there!

Just wanted to reach out to say thanks to https://github.com/WorstPirateYouEverSeen at https://github.com/bsides/horizoverlay/issues/161, I was able to figure out how to get the overlay to behave the way I was looking for via the devtools element.

Simply put, it seems I can get a 4x2 overlay by doing two things: enabling flex wrap in the "combatants" class, and manipulating the width of the overlay

image

image

Couple issues arise though.

One, the width value behaves differently depending on the theme. It seems that for a clean 4x2 overlay on the JRound theme, it requires a width of 75%, whereas for the rest of the themes, it transitions into 4x2 at 74% width.

image

The second issue, which I assume is because the combatants element's width is inherited from and tied to the root, is that the width affects the entire overlay, so the status bar and settings are cut off when the width is too small.

image

The last thing, I'm sure you're aware of, is that because we did these edits in devtools, it only persists on that instance of the overlay and resets to normal after ACT closes or the overlay is disabled and reenabled.

This is a real quick n dirty edit, and I have some HTML knowledge so I can look into it for ya, but I thought I'd keep you updated on what we found. I have a couple ideas already on how to fix this.

dsrkafuu commented 1 year ago

Added in v3.8.0.