search

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package
GNU General Public License v3.0
80 stars 60 forks source link

Signed int #110

Closed hannorein closed 1 year ago

hannorein commented 1 year ago

Hi Dan,

Absolutely not urgent!

Could you check if the signedint branch does anything weird on your end. I've been trying to get rid of some of the compiler warnings about comparisons between signed and unsigned ints and in general just make it a bit more consistent. It's not perfect (e.g. N_active is both a flag "-1" and a counter "0, 1, ..."). I think it should be ok, the unit tests pass, but it's easy to introduce a logic error...

Hanno

dtamayo commented 1 year ago

Hi Hanno, just ran ~10 ipython_examples on both my macbook pro (M1) and a Ubuntu server workstation and everything seems to be working as expected. Let me know if you'd like me to run any more specific tests!

hannorein commented 1 year ago

Thanks a lot Dan! I'll merge it in then.