search

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package
GNU General Public License v3.0
80 stars 60 forks source link

Cannot reproduce the plot in InnerDiskEdge.ipynb #119

Closed wata-tubthong closed 7 months ago

wata-tubthong commented 7 months ago

Hello,

I am new to ReboundX, and I tried to follow InnerDiskEdge.ipynb for the planet migration with inner disk edge. I ran the InnerDiskEdge.ipynb notebook; however, it seems that the planet's semi-major axis keeps decreasing even after it passed the inner disk edge.

temp

I looked into the source code (modify_orbits_force.c) and saw that lines 100-106 were commented out in version 4.0.0. Could this be the reason that I cannot reproduce the plot?

Thank you very much in advance!

dtamayo commented 7 months ago

Hi,

Thanks so much for finding this and tracking it down. It looks like I commented this out while debugging things, and forgot to undo it. I've added it back in, and pushed a new version 4.1.0 to github and PyPI