search

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package
GNU General Public License v3.0
84 stars 63 forks source link

setuptools #12

Closed hannorein closed 8 years ago

hannorein commented 8 years ago

Have a look at this. This solution is somewhat different from the generator trick but it works for me.

I did not find an easy way for the runtime_library_dirs and extra_link_args. I don't know when they are needed (linux?).

This also only works for setuptools, e.g. not distutils. Not sure what to do there? Maybe just require setuptools in the package?

hannorein commented 8 years ago

(clearly something is not working yet)

dtamayo commented 8 years ago

Hm, I have to head home now, but I tried it and (I guess like you found) there’s no attribute runtime_library_dirs or extra_link_args.

The former only works on linux and it sets the rpath for you automatically. The latter is what I had to do if we’re in OS X to set the rpath. Without them it will install, but when you try to load libreboundx.so, it won’t be able to find librebound.so.

That looks very promising though, since the import rebound in the finalize options didn’t fail…I’ll try to look into it if I can

On Feb 19, 2016, at 4:41 PM, Hanno Rein notifications@github.com wrote:

(clearly something is not working yet)

— Reply to this email directly or view it on GitHub https://github.com/dtamayo/reboundx/pull/12#issuecomment-186419248.

hannorein commented 8 years ago

The latest commit seems to fix everything for me. It works on travis, linux and macosx. On macosx I tested both python 2.7 and 3.4.

Tested with the following commands:

    mkdir newer
    cd newer
    virtualenv venv
    source venv/bin/activate
    pip install git+https://github.com/hannorein/reboundx.git
    wget https://gist.githubusercontent.com/hannorein/9d0f7a1b64e0a2fce5fb/raw/a1ec5add13b5fe0e71c0557eec00a46f8b949a29/Migration.py
    python Migration.py
dtamayo commented 8 years ago

Seem to work great! I tested on CentOS python 2.7 and 3.4 and my mac. I added some error messages in case it fails at different points, asking people to contact me if they get the error. That might be the fastest way to find any problems. I'm also giving the planetary discussion on Friday on a reboundx demonstration, so that will be another good test. Thanks again