This fixes the issue in the notebook

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package

GNU General Public License v3.0

80 stars 60 forks source link

This fixes the issue in the notebook #127

Open hannorein opened 3 months ago

hannorein commented 3 months ago

I don't know if this is the right solution!

hannorein commented 3 months ago

Note that REBOUNDx used to use dt_last_done for this effect. See e.g. https://github.com/dtamayo/reboundx/blob/0c1c3735ea6dacbc7ab94e2f08f88e61d09b4bb6/src/modify_orbits_direct.c#L87

hannorein commented 3 months ago

Maybe this is obvious, but why does this effect not work at all (not change to orbital parameters) for integrators other than IAS15/WHfast? E.g. BS, SABA, leapfrog.