search

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package
GNU General Public License v3.0
80 stars 60 forks source link

Spline Interpolation #47

Closed sabaronett closed 4 years ago

sabaronett commented 4 years ago

I'm going ahead and opening the PR so we can begin our final review. Let me know if you have any questions.

sabaronett commented 4 years ago

@dtamayo, do we want to keep both MassEvolution.ipynb and ParameterInterpolation.ipynb in /ipython_examples/, or just the latter?

coveralls commented 4 years ago

Coverage Status

Coverage increased (+12.2%) to 84.833% when pulling fbcbe14dff6222762bbeca118e09b4b5c254f7f6 on sabaronett:spline into b5e35b4eeed8b6b25978d2f087cb535c8bedbbc8 on dtamayo:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+3.4%) to 75.992% when pulling 5a44fda852c8d0a59ab18fefdfa21b9e985ee4aa on sabaronett:spline into b5e35b4eeed8b6b25978d2f087cb535c8bedbbc8 on dtamayo:master.

codecov-io commented 4 years ago

Codecov Report

Merging #47 into master will increase coverage by 0.52%. The diff coverage is 87.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   75.05%   75.57%   +0.52%     
==========================================
  Files          38       40       +2     
  Lines        3431     3586     +155     
==========================================
+ Hits         2575     2710     +135     
- Misses        856      876      +20
Impacted Files Coverage Δ
src/central_force.c 82.53% <ø> (ø)
src/gr.c 93.98% <ø> (ø)
src/gr_full.c 96.65% <ø> (ø)
src/gr_potential.c 91.48% <ø> (ø)
src/gravitational_harmonics.c 98.43% <ø> (ø)
src/modify_mass.c 100.00% <ø> (ø)
src/modify_orbits_direct.c 0.00% <ø> (ø)
src/modify_orbits_forces.c 97.43% <ø> (ø)
src/radiation_forces.c 80.00% <ø> (ø)
src/steppers.c 0.00% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a44fda...5a44fda. Read the comment docs.

sabaronett commented 4 years ago

@dtamayo, I merged https://github.com/sabaronett/reboundx/pull/25 and corrected the only issue I found with 5a44fda852c8d0a59ab18fefdfa21b9e985ee4aa. Thanks for that PR.

My only question is whether you want to reference that new mesa2txt repo in REBOUNDx's documentation at all (e.g., in the C/iPython interpolation examples), or if we'll leave that to our forthcoming implementation paper.

dtamayo commented 4 years ago

Thanks Stanley! Good idea. I added a link to your repo in ParameterInterpolation.ipynb