search

dtamayo / reboundx

A library for adding additional forces to the REBOUND N-body integration package
GNU General Public License v3.0
80 stars 60 forks source link

type_I_migration.c uses clearer function definitions and nomenclature… #85

Closed GabrielePichierri closed 2 years ago

GabrielePichierri commented 2 years ago

… (in particular the quantity that was called sma-damping timescale is now called migration timescale since it represents a change in angular momentum, not in sma), which can resolve some confusions for people who want to implement different migration prescriptions than Cresswell&Nelson2008 while keeping the same framework established in type_I_migration.c. The exampe TypeIMigration.ipynb adds a clarification to what tau_tilde represents (also with respect to the tau_mig calculated in type_I_migration.c)

dtamayo commented 2 years ago

Thanks so much Gabriele, this is great. It seems straightforward so I'll go ahead and merge it, but let me know if anything else needs adding @Kaltrinak and @acpetit!