duc-beluga / gt-planner

GT Planner is a website that provides students with a visual roadmap of their academic journey, making course planning clear and simple.
https://duc-beluga.github.io/gt-planner/
GNU General Public License v3.0
3 stars 2 forks source link

Tailwind test #20

Closed jessicalee2005 closed 8 months ago

jessicalee2005 commented 8 months ago

sorry I'm bad at github so im not sure if I did this correctly ? sorry I just made a new pull request.

I think I redid it using Tailwind ? If this is incorrect I might be stuck so I might need more help during the next meeting

duc-beluga commented 8 months ago

All good, no worries. :)) It seems like you've just created another branch. Try to push the new changes related to the feature to the same branch later on.

duc-beluga commented 8 months ago

You're doing in the right direction. You can actually apply styling directly in the component without creating a CSS class.

Instead of

A.jsx
<div className="container">
  <p> Hello World </p>
</div>

A.css
.container {
  background-color: black;
}

You can

A.jsx
<div className="bg-black">
  <p> Hello World </p>
</div>

Create a CSS file for each component (separation of concerns) is a good approach. However, it will become harder to maintain later on :)) Here's a fun clip about why we're choosing this approach.

https://www.youtube.com/watch?v=lHZwlzOUOZ4&ab_channel=Fireship