duilio / pelican-octopress-theme

Octopress default theme copied for pelican

MIT License

149 stars 119 forks source link

Adding flags to hide tags and categories in sidebar. #57

Closed dhermes closed 9 years ago

dhermes commented 9 years ago

Note this differs from the opt-in convention of settings like DISPLAY_CATEGORIES_ON_MENU.

I figured having something like HIDE_CATEGORIES_IN_SIDEBAR would be easier since None is falsey the default behavior is to make it hidden.

duilio commented 9 years ago

Sorry for the late take on this Pull request. :-) Even if I prefer to save back compatibility, I think the option should be DISPLAY_* instead of HIDE_*. Probably you can use the default jinja2 filter to have sane defaults for these settings.

dhermes commented 9 years ago

@duilio ISTM that #66 covers this, I'll re-open if I'm incorrect.

duilio commented 9 years ago

66 was about the main navigation and it's merged now, #67 cover changes also for sidebar.