sidebar extended - Githubissues

duilio / pelican-octopress-theme

Octopress default theme copied for pelican

MIT License

149 stars 119 forks source link

sidebar extended #67

Closed mstreuhofer closed 7 years ago

mstreuhofer commented 9 years ago

display categories and tags in the sidebar only if requested
display feeds in social section of the sidebar only if requested
SIDEBAR_IMAGE + AUTHOR_ABOUT:

SIDEBAR_IMAGE wont be shown unless AUTHOR_ABOUT is also set

That whole sidebar image was a mess-- still is, just a little less so. only the image would look like spit. it would not have proper margins as there would be no section heading. so we won't allow it (for now).

If AUTHOR_ABOUT is set then a section with the heading "About" gets rendered. Within this section a possibly set SIDEBAR_IMAGE gets displayed. It will be floating to the right. Proper margins will be set to have the text of AUTHOR_ABOUT not touch the SIDEBAR_IMAGE.

duilio commented 9 years ago

Conflicts

duilio commented 9 years ago

Please note that the default values for both the DISPLAY_TAGS and DISPLAY_CATEGORIES settings, should be True. Here is another PR for these specific settings: https://github.com/duilio/pelican-octopress-theme/pull/57. Probably we could split the other changes of this merge.

mstreuhofer commented 9 years ago

since this PR changes README.rst it will conflict with PR #60 and #66. but you are right about #57 so i will try to rework the whole thing and possibly make everybody happy. ignore this PR for now. i'll update you.

duilio commented 9 years ago

Ok, waiting for the update.

dhermes commented 9 years ago

Seems DISPLAY_CATEGORIES could apply to archive.html as well.

mstreuhofer commented 9 years ago

good point. since i'll have to rethink/rework that whole thing anyway i'll certainly keep that in mind. maybe even extended to everywhere categories are displayed (all kind of index pages). the same with tags i guess. thanks.

duilio commented 9 years ago

Ok, now we are ready for this one as well, I think.