search

duilio / pelican-octopress-theme

Octopress default theme copied for pelican
MIT License
149 stars 118 forks source link

Regression: github projects sidebar #79

Open mtstickney opened 9 years ago

mtstickney commented 9 years ago

Commit ceb48372fa2148188a7522a794fdc37d20f32f1b moved external scripts from <head> to the <body> tag, which has broken the github projects sidebar. The sidebar uses javascript that depends on ender.js, but the sidebar script is inserted before the ender <script> tag after this change, so the projects are never loaded.

The fix is either to a) move the script tags above the sidebar include, or b) put them back in <head>. I didn't make a pull request, since I'm not sure which way you want to go, but I can if you'd like.

Edit: bah, markup problems.

atodorov commented 8 years ago

For the record this has been fixed in https://github.com/duilio/pelican-octopress-theme/commit/3cb2628f3e124df79beea62ba5ad672a8ecb1223 and can be closed.