search

dukecon / dukecon_html5

MIT License
2 stars 3 forks source link

Frontend dismisses linefeeds in abstracts #57

Closed ascheman closed 8 years ago

ascheman commented 8 years ago

The frontend silently drops white space in abstracts, e.g., 509505 has two paragraphs, which ist not the case in DukeCon: https://dukecon.org/javaland/talk.html#talk?talkId=509505

Data as provided by DOAG back office is delivered with Windows line endings (i.e., '\r\n'). I would like to drop the '\r' completely in the future since it is also contained in some of the title data but without the '\n' (at the end). So a solution for the frontend should be fault tolerant regarding this differences.

@chrisdutz what about the Flex client, should this be solved there also?

sippsack commented 8 years ago

dukecon_server now replaces \r\n with \n only html5 client replaces \n with
in abstract text only

sippsack commented 8 years ago

@steffchep, @annam002: can you have a look at my commits. I've replaced \n with
. But I had to disable html encoding to line breaks get rendered correctly. What about cross site scripting?

annam002 commented 8 years ago

Maybe we can first html-escape the text and then insert the break tags?

annam002 commented 8 years ago

I escaped potential html characters in the abstract in addition to@sippsack s changes