search

dungtruongtien / kewe-crawler

0 stars 0 forks source link

Start of the code review process 👋 #18

Open longnd opened 7 months ago

longnd commented 7 months ago

Hello 👋 , thank you for your effort on the code submission. I am Long, engineering lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, and thus I will create issues where I think there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to raise your questions or share your opinions about the implementation (if any) during the process.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Please note that you don't have to close any of my created issues after merging your PRs, I will help verify and close them for you once they pass. 😇

We expect the code review process to be completed within 2-3 days at most. As a result, ensure you are responsive during this process. If you need additional time, please inform us right away so that we can plan accordingly.

In the end, I really do hope that you find the process enjoyable. Good luck and happy coding. 🤘

longnd commented 7 months ago

@dungtruongtien thank you for the replies on the opened issues. I have now completed my review. It is time to wrap up this stage of the code review process. Thank you for your efforts so far. Our TA team will provide feedback to you by email shortly.

dungtruong411 commented 7 months ago

Hi @longnd, thanks a lot for your advice. they're all helpful to me.

Sorry about the bad experience that you cannot run my project easily even with a local machine or docker. I've investigated and that issue was related to Postgres init statement (kewe_crawling database was not created). Maybe next time I'll put the migration directly in the codebase for development env.

Btw, thanks so much for your feedback on this project.