search

dungtruongtien / kewe-crawler

0 stars 0 forks source link

[Chore] Add test for the Google Scraper #24

Open longnd opened 1 year ago

longnd commented 1 year ago

Issue

Automated tests do not cover the core business logic: scraping.

Expected

While 100% test coverage is not required for this code challenge, all critical paths of the application should be unit-tested (and, ideally, UI-tested). So the following should be covered:

dungtruongtien commented 1 year ago

Sorry about this missing. However, I don't have time and experience in writing unit tests for scraping. So that's why I have to focus on the basic feature, and test it manually first.

longnd commented 1 year ago

understood; thank you for the insight.