Closed randomir closed 6 months ago
@randomir out of curiosity, it looks like there is still a bit of creeping memory usage in the second image as well. Is that just an artifact of the test or are there other memory leaks or pseudo-leaks?
@arcondello, I'm not sure. Haven't seen other circular refs in the client-solver-future constellation, but to make sure, I plan to analize it properly. Also, I want to look broader, across the whole Ocean.
Related, 400MiB for a single QPU sampling is abhorrent, IMO.
But all this can be tackled under the QPU path performance improvements umbrella.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.47%. Comparing base (
f3614c8
) to head (b90794f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fix #601.
Running the test snippet from #601:
before the fix:
and after the fix: