search

dwellir-public / polkadot-operator

The Polkadot Juju operator/charm
Apache License 2.0
1 stars 1 forks source link

Added wasm-runtime-url config #49

Closed jonathanudd closed 7 months ago

jonathanudd commented 8 months ago

This is something that I should have added a long time ago but better late than never I guess.

I know we are phasing out the use of runtime overrides due to tracing support being included without it. So the reason I'm adding this now is that we have a customer who wants evm tracing on Astar nodes and that requires a specific runtime https://docs.astar.network/docs/build/nodes/evm-tracing-node I know Moonbeam also has something similar that requires overriding of the runtime as well and it might be more.

Astar includes a archive with a node binary plus runtimes that needs to be used for tracing and we will need to download that archive and upload the files somewhere to be used as download links in the charm e.g our nextcloud. This is not ideal but I didn't want to add special cases for this in the charm for Astar evm tracing.

This PR includes

I have tested deploys with various combinations of binary-url, wasm-runtime-url and chain-spec-url (since I changed the code for it)

jonathanudd commented 8 months ago

I just noticed this in the docs

Tracing data at a certain block requires to override the runtime version of this block. To use tracing on an ancient blocks, you need to add the runtime that was in place at this block.

So depending on the need of the customer this is not enough.

Maharacha commented 8 months ago

I just noticed this in the docs

Tracing data at a certain block requires to override the runtime version of this block. To use tracing on an ancient blocks, you need to add the runtime that was in place at this block.

So depending on the need of the customer this is not enough.

What would those needs be? What could be done differently?

jonathanudd commented 8 months ago

What would those needs be? What could be done differently?

Astar provides an archive with all runtimes built for evm tracing https://shared-assets.astar.network/files/runtime/astar-tracing-runtimes-3-69.tar.gz

My suggestion is that we either support both a single file and an archive or only an archive (which could contain only one file) for the wasm-runtime-url config.

The customer who has requested this wants to support for ancient blocks so we need to support it at least.

Maharacha commented 8 months ago

What would those needs be? What could be done differently?

Astar provides an archive with all runtimes built for evm tracing https://shared-assets.astar.network/files/runtime/astar-tracing-runtimes-3-69.tar.gz

My suggestion is that we either support both a single file and an archive or only an archive (which could contain only one file) for the wasm-runtime-url config.

The customer who has requested this wants to support for ancient blocks so we need to support it at least.

Sounds like we need to support an archive then. And if it's not too complicated, support a single file as well, without it being archived.