search

dwellir-public / polkadot-operator

The Polkadot Juju operator/charm
Apache License 2.0
1 stars 1 forks source link

Clean up constants based on file/dir #65

Closed ZeeshanM96 closed 5 months ago

ZeeshanM96 commented 6 months ago

Description:

Constants in the constants.py should be named after what they represent e.g. _DIR for directories and _FILE for files.

Testing Screenshots:

jujustatus

logs

image

awnns commented 6 months ago

I believe the USER constant was supposed to remain. There is a separate constant for the user's home directory already.

awnns commented 6 months ago

Also probably, we should use names like "HOME_DIR" instead of "HOME_PATHDIR" in the interest of avoiding https://en.wikipedia.org/wiki/Tautology(language).

ZeeshanM96 commented 6 months ago

@awnns I tried looking up for USER_DIR, and couldn't find any. All of the USER_DIR are coming from the constant.py file. Please correct me if I am wrong.

Screenshot from 2024-05-10 10-22-37

awnns commented 6 months ago

@awnns I tried looking up for USER_DIR, and couldn't find any. All of the USER_DIR are coming from the constant.py file. Please correct me if I am wrong.

Screenshot from 2024-05-10 10-22-37

image

ZeeshanM96 commented 6 months ago

@jonathanudd @awnns i have made the naming convention better. Please have a look and let me know if you have any remarks