search

dwins / mapnik2geotools

Using the Scala XML API to translate from Mapnik XML to GeoTools' SLD dialect
64 stars 22 forks source link

Suggesting two minor fixes #30

Closed nrenner closed 12 years ago

nrenner commented 12 years ago
  1. The new mapnik2 package for TextSymbolizerTransformer was missing in Mapnik2GeoToolsSpec
  2. Use 0.7.2 as minimum version for Mapnik2 syntax

upgrade_map_xml.py inserts 'minimum-version="0.7.2"' as this is the first version to support Mapnik2 syntax (see links below). So when comparing to <= 7 the upgraded osm.xml fails. Therefore I would suggest to draw the line between 0.7.1 and 0.7.2.

[1] http://trac.mapnik.org/wiki/Mapnik2#UpgradeGuide [2] http://trac.mapnik.org/wiki/Mapnik2/Changes#GlobalChanges

dwins commented 12 years ago

thanks, i thought I'd updated the tests after that last refactoring.