Line fitting: improve by using orthogonal distance as error and providing a guess

dwkim78 / ASTRiDE

AUTOMATED STREAK DETECTION FOR ASTRONOMICAL IMAGES

MIT License

49 stars 23 forks source link

Line fitting: improve by using orthogonal distance as error and providing a guess #30

Open michaelbaisch opened 2 months ago

michaelbaisch commented 2 months ago

Simply using the y difference as an error for line fitting results in worse fits as lines approach vertical. Using the orthogonal difference solves this problem.
Provide a guess for line fitting by calculating the most distant contour points earlier and using the parameters of a line through them.
Vertical lines were tested and a comment was added; they do not pose a serious problem.

fixes #29

michaelbaisch commented 2 months ago

Screenshot 2024-09-06 at 14 08 47

dwkim78 commented 2 months ago

Hi Michael,

Thanks for the fix. I've been busy these days and couldn't check the code. I'll check the code soon and merge them accordingly.

Cheers,

Update: I'll do my best to get back to this pull request as soon as possible. I'm busy because my first baby has just been born (I don't even have time to log on to my computer these days...).