search

dwkim78 / ASTRiDE

AUTOMATED STREAK DETECTION FOR ASTRONOMICAL IMAGES
MIT License
49 stars 23 forks source link

Support creating Streak instance with data instead of filename #31

Open michaelbaisch opened 2 months ago

michaelbaisch commented 2 months ago

Hello,

I believe it would be very useful to create a Streak instance by passing image data and optionally a WCS instance. Currently, only passing a filename to a FITS file is possible. This limitation prevents easy modification of the image beforehand (without writing it to disk and passing that path), which could be very useful, for example, for rebinning.

I suggest adding another way to create a Streak instance with the image data and optionally a WCS instance. As far as I can see, the FITS header is only used for wcsinfo. Therefore, I also propose storing the WCS as an instance variable and using it in the xy2sky() methods directly, without reading the FITS header from disk again.

Greetings, Michael

dwkim78 commented 1 month ago

Hi Michael,

This sounds really good.

Cheers,