Review timer functions

[SimonLab]

I've noticed a few things that I want to update or have a detailed looked at to make sure I didn't miss something:

    {:ok, _timer} =
      Timer.start(%{
        item_id: item.id,
        person_id: person_id,
        start: NaiveDateTime.utc_now()
      })

• [x] Remove the person_id value as the schema doesn't have it:

  schema "timers" do
  field :item_id, :id
  field :start, :naive_datetime
  field :stop, :naive_datetime
  
  timestamps()
  end

• [ ] Make the stop function consistent with the start, ie pass the stop value as parameter:

  {:ok, _timer} = Timer.stop(%{id: timer_id})

• [ ] Combine start/stop function to update function

• [ ] Review how toggle stop the timer. This mean that when a done item returns to active status we also stop the timer again?

  def handle_event("toggle", data, socket) do
  # Toggle the status of the item between 3 (:active) and 4 (:done)
  status = if Map.has_key?(data, "value"), do: 4, else: 3
  
  # need to restrict getting items to the people who own or have rights to access them!
  item = Item.get_item!(Map.get(data, "id"))
  Item.update_item(item, %{status: status})
  Timer.stop_timer_for_item_id(item.id)
  
  AppWeb.Endpoint.broadcast(@topic, "update", :toggle)
  {:noreply, socket}
  end

[nelsonic]

@SimonLab these are all valid questions. agree with removing person_id from the Timer.start 👍 Timer.stop should allow the passing of the stop value but should default to now.

[SimonLab]

I've started to break to many things. I need to review first this section to understand fully how the item/timers structure is created: https://github.com/dwyl/mvp/blob/7e94e47a831a8436bfc97a8e8d1d1171e5ef8c25/lib/app/item.ex#L97-L247

I think the functions linked to the timers are correct and I misunderstood the structure

[nelsonic]

@SimonLab yeah, the disclaimer was my attempt to warn you. 🤪 If you can wrap your head around it, I’m very happy for you to attempt to simplify it. But it needs to be time-boxed. 👌🏻

[nelsonic]

@SimonLab if you have time to review this please go for it. 🤞