dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

Run mix format #186

Closed SimonLab closed 1 year ago

SimonLab commented 1 year ago

Fix format error on router.ex

ref: https://github.com/dwyl/mvp/issues/183#issuecomment-1285160054

codecov[bot] commented 1 year ago

Codecov Report

Merging #186 (81dc26e) into main (bc8d2b3) will decrease coverage by 1.35%. The diff coverage is n/a.

@@             Coverage Diff             @@
##              main     #186      +/-   ##
===========================================
- Coverage   100.00%   98.64%   -1.36%     
===========================================
  Files           13       13              
  Lines          218      221       +3     
===========================================
  Hits           218      218              
- Misses           0        3       +3     
Impacted Files Coverage Δ
lib/app_web/router.ex 100.00% <ø> (ø)
lib/app_web/live/app_live.ex 96.10% <0.00%> (-3.90%) :arrow_down:
lib/app/tag.ex 100.00% <0.00%> (ø)
lib/app/item.ex 100.00% <0.00%> (ø)
lib/app_web/controllers/auth_controller.ex 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SimonLab commented 1 year ago

The codecov project status is failing because the empty line as been removed: image

I don't think this report is useful on this PR

nelsonic commented 1 year ago

Very bizarre that this is lowering coverage ... 🤷‍♂️

SimonLab commented 1 year ago

am I right in thinking this PR just adds whitespace? man_shrugging

Yes I think the formatter might have removed a special character (maybe a tab?)

nelsonic commented 1 year ago

@SimonLab thanks for confirming. Merging. ✅