dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

[PR] Updating README and BUILD. #192

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

fixes #190

As requested, here's the PR of the changes to README and possibly BUILD while running the MVP.

codecov[bot] commented 1 year ago

Codecov Report

Merging #192 (56a956d) into main (81b1d2f) will increase coverage by 1.35%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #192      +/-   ##
===========================================
+ Coverage   98.64%   100.00%   +1.35%     
===========================================
  Files          13        13              
  Lines         221       221              
===========================================
+ Hits          218       221       +3     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
lib/app_web/live/app_live.ex 100.00% <0.00%> (+3.89%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

Just got through replicating the project and I fixed/clarified some aspects as I was reading, implementing, and testing.

Overall, it's a great read and very detailed, so not much was needed to change. But sometimes I was stumped because I didn't know where I should use some code snippets. It should be more clear now 😄