search

dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

Moving edit item to its own page? #214

Open SimonLab opened 1 year ago

SimonLab commented 1 year ago

With the addition of new features, the edit item content start to get big: image

Also having all the code for editing the item on the same page as creating and listing items make it difficult to manage, see #105

I think it would make sense to display an "edit" link for each items on the list and managing all the edit on another endpoint/page.

Do you think this makes sense?

LuchoTurtle commented 1 year ago

Agreed 👍 I quickly realized this while testing and I wanted a way to delete timers as well. But it was merged just so we could get early feedback on it. I can take this issue if @nelsonic agrees if it's a priority or not.

nelsonic commented 1 year ago

@SimonLab thank you very much for opening this issue. 🙌 Totally agree that it looks cluttered especially when viewed on a Desktop. 🖥️ https://github.com/dwyl/mvp/issues/202 Also 100% agree that the code is difficult to manage ... 😕
hence: https://github.com/dwyl/mvp/issues/105 our oldest open issue. 🔥

I don't have anything against having a separate "edit" page for items. 📄 However, I will say that on the [Flutter] Mobile App I think taping on an item.text should just expand the item "edit mode" to full-screen rather than transitioning to a separate page.

All of this is semantics because if we adopt an API-driven approach (which is what we need to do!), then POST items/:cid/edit is what we need to focus on.

None of the UI/UX for our App is even close to being "set in stone", so let's just figure out what makes sense now for MVP.

If we can use a transition to ease the change from the "all items" view to the Edit item view, it will be good. 💭

Go for it. 👌

nelsonic commented 1 year ago

@SimonLab did you make progress with this shift? 🧑‍💻 Or can I spend some time defining it in Figma so that we're all clear? 💭