Closed nelsonic closed 1 year ago
Anyone in the community of contributors is welcome to pick this up as a good first issue
. 👌
@nelsonic Hello! I'd love to take a wack at it if this is still available.
Hey @DuldR 👋
This 100% still an issue. 💯
You have write
access to the repo, see: https://github.com/dwyl/mvp/invitations 🦄
Please create a branch
in the repo and Go for it! 🙌
(hopefully the above instructions are clear ... but if not, ask! 🙏)
P.S: visit https://github.com/dwyl to accept Org Membership invitation 📥 P.P.S: Don't forget to ⭐ the repo if you find it interesting/useful. 🌟
Added some questions over at the PR - https://github.com/dwyl/mvp/pull/225
@DuldR replied to your questions in the PR: https://github.com/dwyl/mvp/pull/225#issuecomment-1335058743 Thanks again! 👌
Thank you for the feedback! Marked ready for review.
Merged. Thanks again! 🎉
Follow-up quest: #226 / #227 (sadly this one has to be done by me cause I have to publish a new version ... 🙄)
In light of https://github.com/dwyl/auth_plug/issues/86 we can now call:
Todo
[x] Create a new
branch
for updating the code.[x] Replace both the instructions in the
BUILDIT.md
https://github.com/dwyl/mvp/blob/main/BUILDIT.md#62-create-auth-controller
https://github.com/dwyl/mvp/blob/4d430b3459645ef52703b6342eca3e199ca3f75d/lib/app_web/controllers/auth_controller.ex#L5-L18
Can just be:
Which DRYs up this code very nicely.
"PR: DRY Assign JWT to Socket Code issue #215"