search

dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

Add "create tag" in select input #222

Closed SimonLab closed 1 year ago

SimonLab commented 1 year ago

Please feel free to discard/close this PR, see https://github.com/dwyl/mvp/issues/221#issuecomment-1332004568

It is in example how a tag can be created from the select input. As mentioned in the issue, this is not a prefect UX, this PR can be used for testing and discussion.

nelsonic commented 1 year ago

@SimonLab feels like we need "review apps" to discuss ... https://github.com/dwyl/learn-devops/issues/85 💭

SimonLab commented 1 year ago

Yes I will look at how we can create review apps with Fly. In the meantime I've created the PR to allow people to test it on localhost

SimonLab commented 1 year ago

image

Clicking on the "create my new tag" will create the tag and select it before resetting the search tag input: image

nelsonic commented 1 year ago

The concept of having to manually "Create new tag" is a UX antipattern that takes the person out of the flow of "Capture" mode and into "admin". We aren't going to do this as outlined in: https://github.com/dwyl/mvp/issues/221#issuecomment-1404384279

SimonLab commented 1 year ago

To clarify if we need to search code from this PR, the feature added here doesn't redirect to another page. The create link call some liveview code which creates the tag and update the UI with the tag pill