Closed nelsonic closed 1 year ago
Side-quest: https://github.com/dwyl/logs/issues/1
Conflicts for the envar and fields dependencies:
I also have the following error after getting the latest version from main:
I'll try to update auth_plug only to have a stable version running
Yeah, I know right ... π π€¦ββοΈ Please help investigate: https://github.com/dwyl/hits/issues/203 π
I've arrived at the same step as you, I had to update envar then fields. I'm wondering if it's not an issue with hex packages not being available (cdn broken?). I'm not sure the hits issue is the same as this one however
Nah, this is just a deps mismatch. It will all be resolved shortly. I'm just writing up on my side. happy to screen-share if you want to pair. But otherwise please look at the issue above (get Hits working) π
Merging #227 (4629234) into main (69a4b78) will decrease coverage by
0.32%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #227 +/- ##
===========================================
- Coverage 100.00% 99.67% -0.33%
===========================================
Files 13 13
Lines 312 309 -3
===========================================
- Hits 312 308 -4
- Misses 0 1 +1
Impacted Files | Coverage Ξ | |
---|---|---|
lib/app_web/controllers/auth_controller.ex | 100.00% <ΓΈ> (ΓΈ) |
|
lib/app_web/live/app_live.ex | 99.07% <0.00%> (-0.93%) |
:arrow_down: |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
Removing empty line push down the coverage:
But otherwise the dependencies conflict are now resolved. @nelsonic merging this one now should allow #225 to be deployed now
@SimonLab If you're happy to merge, please go for it. π
Latest closed PR deployed on Fly! https://github.com/dwyl/mvp/actions/runs/3630669228/jobs/6124323471
This PR will only pass once all the
deps
are updated. I will assign when ready.