dwyl / mvp

📲 simplest version of the @dwyl app

https://mvp.fly.dev

GNU General Public License v2.0

84 stars 2 forks source link

[PR] Adding basic table and metrics page #250

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #245

Adds a simple table with the person_id, number of items and numbers of timers created:

codecov[bot] commented 1 year ago

Codecov Report

Merging #250 (5b2cb02) into main (85b5cab) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        12    -1     
  Lines          309       309           
=========================================
  Hits           309       309

Impacted Files	Coverage Δ
lib/app/tag.ex	`100.00% <ø> (ø)`
lib/app/timer.ex	`100.00% <ø> (ø)`
lib/app/item.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/app_live.ex	`100.00% <100.00%> (ø)`
lib/app_web/live/stats_live.ex	`100.00% <100.00%> (ø)`
lib/app_web/router.ex	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nelsonic commented 1 year ago

Review App: https://mvp-pr-250.fly.dev not fully loading (doesn't connect to web sockets...)

See: https://fly.io/apps/mvp-pr-250/monitoring

nelsonic commented 1 year ago

@SimonLab could you please take a quick look at this and understand why the coverage is missing that line? 🔍 And if possible get the review app working too. 🤞

SimonLab commented 1 year ago

Codecov seems broken for me:

Same for you?

LuchoTurtle commented 1 year ago

Can't access either :/

Which is weird, Codecov says it's fully operational.

Had to check Twitter or something to see if we're alone but a handful of people seem to have the same problem.

SimonLab commented 1 year ago

Re run the tests, coverage updated

SimonLab commented 1 year ago

Related to the review apps, I think the socket connection issue is linked to how fly deployed the application (my latest PR review apps has been deployed and work, which make me think the issue is specific to this application and hopefully just a one of). You can still access the stats endpoint https://mvp-pr-250.fly.dev/stats

However because review apps create a new database at the moment the table is empty