dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

[PR] Adding Papertrail and recording changes #255

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

closes #252

Integrates PaperTrail to track changes when updating/inserting items.

codecov[bot] commented 1 year ago

Codecov Report

Merging #255 (74b333d) into main (9b7c286) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #255   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          309       310    +1     
=========================================
+ Hits           309       310    +1     
Impacted Files Coverage Δ
lib/app/item.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

Guess the People table is a no-go https://github.com/dwyl/mvp/pull/250#discussion_r1065757858 Gonna change this tomorrow.

nelsonic commented 1 year ago

@LuchoTurtle indeed. people table was removed in https://github.com/dwyl/mvp/issues/118 ✅ Please rebase on main and it should be good to go. 👌

LuchoTurtle commented 1 year ago

@nelsonic should be mergeable. The reason "the coverage dropped" is because of the "bug" of formatting that also occurs in https://github.com/dwyl/mvp/pull/246#issuecomment-1370926216 😦

nelsonic commented 1 year ago

Will take a look at this one next. 👌