dwyl / mvp

📲 simplest version of the @dwyl app

https://mvp.fly.dev

GNU General Public License v2.0

84 stars 2 forks source link

Chore: Avoid creating Review Apps for @dependabot PRs #259

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

Just noticed that review apps script runs on @dependabot PRs: https://github.com/dwyl/mvp/pull/257

There doesn't appear to be any check for the branch name in: https://github.com/dwyl/mvp/blob/main/.github/scripts/review-apps.sh

@SimonLab could you please confirm my understanding? 🙏

The @dependabot PRs have dependabot/ in the the branch name dependabot/hex/petal_components-0.19.8 So we can easily detect them and avoid creating a Review App when one is not needed. 💭

SimonLab commented 1 year ago

Check author of the PR: https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#accessing-and-using-event-properties

Run job only when condition is ok (using if): https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution

SimonLab commented 1 year ago

260 PR should fix this issue.

Once merged we can check on the next Dependabot PRs if the github action is skipped.

nelsonic commented 1 year ago

@SimonLab thanks for addressing this so swiftly. 👍

SimonLab commented 1 year ago

New Dependabot PR:

The review app action is skipped

nelsonic commented 1 year ago

Thanks again @SimonLab 👍