dwyl / mvp

📲 simplest version of the @dwyl app

https://mvp.fly.dev

GNU General Public License v2.0

84 stars 2 forks source link

[PR] Adding Hoppscotch CLI testing #276

Closed LuchoTurtle closed 1 year ago

LuchoTurtle commented 1 year ago

related to #268

This PR will add Hoppscotch CLI testing for API definition testing.

codecov[bot] commented 1 year ago

Codecov Report

Merging #276 (e8df017) into main (261924f) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          414       414           
=========================================
  Hits           414       414

Impacted Files	Coverage Δ
lib/app/timer.ex	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle commented 1 year ago

Testing the API definition is essentially done.

Going to focus now on commenting the results in the PR.

Jobs are running separately and concurrently. The Review App job necessitates the successful completion of both build and the newly created api_definition jobs.

All the files needed to setup and run the API definition tests fall under the .hoppscotch directory.

LuchoTurtle commented 1 year ago

The CI passes. The test coverage lowered because of that darn line of diff > 1000 :/

nelsonic commented 1 year ago

Cool. I will pick this up now and address the annoying line that keeps failing coverage. 🧑‍💻

nelsonic commented 1 year ago

The screenshots in https://github.com/dwyl/mvp/blob/3f03a1a7ff963489b06f399aac702a736df1ce0d/API.md#71-using-hoppscotch are a bit "off" ... some are unconstrained e.g:

What's up with all this whitespace? 🤷‍♂️

And then further down, the screenshots are tiny:

Forcing me to click into the images to enlarge them.

The images are:

<img width="49%" alt="import1" src="https://user-images.githubusercontent.com/17494745/213747810-d2c0ba75-a7a2-4b98-a5b0-abd17c079faf.png">
<img width="49%" alt="import2" src="https://user-images.githubusercontent.com/17494745/213747822-d855450a-71e1-40ef-b0ab-600b20587238.png">

Why width="49%" ? 🤷‍♂️

Again, I feel like this was written in a hurry and assigned to me without self-review. 💭 I'm tidying up the screenshots in "Zen Mode" to avoid the noise and excess whitespace. ⏳