[PR] Upgrading to Phoenix 1.7

[LuchoTurtle]

closes #322

This PR upgrades the project to Phoenix 1.7.

Following https://gist.github.com/chrismccord/00a6ea2a96bc57df0cce526bd20af8a7.

[LuchoTurtle]

Getting the following error.

== Compilation error in file lib/app_web/live/stats_live.ex ==
** (CompileError) lib/app_web/live/stats_live.ex:3: module Phoenix.View is not loaded and could not be found. This may be happening because the module you are trying to load directly or indirectly depends on the current module
    expanding macro: AppWeb.__using__/1
    lib/app_web/live/stats_live.ex:3: AppWeb.StatsLive (module)
    (elixir 1.14.3) expanding macro: Kernel.use/2

Might have to replace occurrences with Phoenix.Template 🤔

[codecov[bot]]

Codecov Report

Merging #323 (a83b8cf) into main (a30aa78) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #323   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          475       475           
=========================================
  Hits           475       475           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[nelsonic]

@LuchoTurtle are you following Chris' Upgrade guide: https://gist.github.com/chrismccord/00a6ea2a96bc57df0cce526bd20af8a7 ?

[LuchoTurtle]

I am, I mentioned it in the PR

[nelsonic]

@LuchoTurtle just did the update on https://github.com/dwyl/phoenix-liveview-realtime-cursor-tracking-tutorial/pull/31/files and it works well. ✅

[nelsonic]

I'm not offended by the addition of:

{:phoenix_view, "~> 2.0"},

To the mix.exs -> deps to avoid as many updates.

[LuchoTurtle]

I didn't want to follow https://elixirforum.com/t/module-phoenix-view-is-not-loaded-and-could-not-be-found/52362 and add the {:phoenix_view, "~> 2.0"}, dependency, but since @nelsonic stated that it was ok, I went for it. I fixed some warnings that came with this upgrade as well.

I initially wanted to do a more thorough upgrade, removing the soft-deprecated helpers and making full use of verified routes. But since it is intended to be an upgrade without many changes, I'll leave it at here.

Additionally, the reason I changed MVP.json was because there was a duplicate test.