search

dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
87 stars 2 forks source link

chore(typos): fix typos #331

Closed stavares843 closed 1 year ago

stavares843 commented 1 year ago

Fix typos across codebase.

LuchoTurtle commented 1 year ago

@nelsonic 10 tests are failing because of AuthPlug.Token.generate_jwt!/1. Was auth changed at any point? 👀

nelsonic commented 1 year ago

@stavares843 thanks very much for proactively fixing these! 🥇 @LuchoTurtle nothing has changed in auth or auth_plug all my work is on branches. ⏳ I don't understand why this is failing. 🤷‍♂️ I just merged https://github.com/dwyl/mvp/pull/330 and the build passes on main: https://github.com/dwyl/mvp/actions

image

https://github.com/dwyl/mvp/actions/runs/4352536248

image

So I say we should just merge this and see if it AuthPlug.Token.generate_jwt!/1 resolves itself. I suspect that it has something to do with @stavares843 creating the PR off a fork which means that her CI build doesn't have access to the AUTH_API_KEY ... 💭

LuchoTurtle commented 1 year ago

@nelsonic I'm merging on your assumption being correct, then 👍