dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

Chore: Restore Missing Metrics/Stats Docs #349

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

As noted in https://github.com/dwyl/mvp/pull/345#issuecomment-1501199486 the docs for Metrics are missin from the main branch: https://github.com/dwyl/mvp/blob/main/BUILDIT.md#14-adding-a-dashboard-to-track-metrics

image

Only the section heading remain ... 🤷‍♂️

Appear to have been changed in merge conflict resolution: https://github.com/dwyl/mvp/blame/02869e8904dad19b4a71a2c6d306ce4376a67d1c/BUILDIT.md#L4742

image

I must have missed the deletion in a previous PR ... 🙈

Todo

@LuchoTurtle please:

LuchoTurtle commented 1 year ago

Closing due to being a duplicate of https://github.com/dwyl/mvp/issues/348

nelsonic commented 1 year ago

The issue I created contains more detail and a clear task. ✅ Just because I'm typing one-handed and taking my time to investigate the issue 🔍 so my issue was opened a couple of minutes after yours doesn't make my issue the "duplicate"... 🤣 If anything, the issue created by a Product Owner always supersedes.

Closing my issue and then posting a comment that there's "more info" in it:

image

Just makes you look like you're wasting the time of the reader and too lazy to copy over the additional info.

Top Tip: if your " boss" has made the effort to open a task, don't step on their toes by closing the work they just did. It's never helpful/welcome. There are 100 other things you could be doing instead. And on a Sunday night when I'm trying to clear my notifications and prepare for the week ahead, wasting my time with this kind of nonsense is like a huge slap in the face.

slap

Just Don't Do it.

nelsonic commented 1 year ago

image

LuchoTurtle commented 1 year ago

Closing my issue https://github.com/dwyl/mvp/issues/348 in lieu of this one given the feedback above.