search

dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

BUG: empty `item` being created #361

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

while testing the MVP on localhost I keep seeing this empty item (no text)

dwyl-mvp-null-item-created

This is the record in the items table:

dwyl-mvp-null-item-person_id-2

I'm reading this line of code:

https://github.com/dwyl/mvp/blob/a95bbdc69b4ee8fe808ca78430ae38e6cbea5c71/lib/app_web/live/app_live.ex#L61

And I'm not understanding why we would ever want to save an item with text="" (empty) ... 🤷‍♂️

Note: this issue is not prioritised because I feel that it only exists because we are doing tags in a non-intuitive way ... ref: https://github.com/dwyl/mvp/issues/221#issuecomment-1404384279 i.e. the problem of saving a blank item is a symptom of the root cause: incoherent experience. And it's 100% my "fault". So I will fix it. 👌

nelsonic commented 1 year ago

No longer seeing this issue so closing. If I see it again will re-open. 👌