Closed nelsonic closed 2 years ago
@SimonLab the code is mostly there for the MVP. If you want to take a look at it now, please go for it.
I've not had much focus time these last few days ... 🙄 really want to finish the README.md
... ⏳
If you want to change any part of the code, please go for it. I will reflect your updates in the README.md
📝
But please avoid any large refactors. we can put those in the "real" App. 💭
Minor detour: https://github.com/dwyl/app-mvp/issues/115 person
being inserted multiple times! 🤦♂️
Do we need to have a people
table in the MVP at all? 💭 >> https://github.com/dwyl/app-mvp/issues/118
Removing the people
table as discussed/concluded in: https://github.com/dwyl/app-mvp/issues/118#issuecomment-1206248882
Successfully removes people
schema/table from the project: https://github.com/dwyl/app-mvp/commit/316929c39888ea3285f6d42324844f95231f588e ✂️
New ERD:
Everything still works as expected. 📝 ⏳ ✅ That's it! The MVP in a nutshell. Two tables.
Coverage hasn't dropped, it's just not being accurately recorded on my Mac ... 🙄
@SimonLab I've finished updating
the README.md
: https://github.com/dwyl/app-mvp/blob/phoenix-1.6-2022-refresh-issue-%2389/README.md 📜
and BUILDIT.md
dev log: https://github.com/dwyl/app-mvp/blob/phoenix-1.6-2022-refresh-issue-%2389/BUILDIT.md 🧑💻
Please take a look and give feedback when you can. 🙏 Thanks again for your patience on this. 👍
Final GIF
:
After removing people
table had to run:
ALTER TABLE items
RENAME COLUMN status_code TO status;
DROP INDEX items_person_id_index;
ALTER TABLE items DROP CONSTRAINT items_person_id_fkey;
ALTER TABLE timers DROP CONSTRAINT timers_person_id_fkey;
DROP TABLE people;
@SimonLab your suggested fixes merged into the PR #90 ✅ Please review again when you can. 🙏
PR #90 merged, we can start the last checkbox item: iterate
Thanks again @SimonLab 🎉
This project is a bit out-of-date. Let's fix that and add @dependabot to keep it up-to-date!
Todo
new
Phoenix@1.6.10
project 🆕auth_plug
so we leverageauth
from the start. https://github.com/dwyl/app-mvp-phoenix/issues/104auth
is not required to create items. i.e optional.item
using basic interfaceitems
are automatically added to a single list (separate lists can follow later)items
are considered to betasks
for now and thus have a timer (start) button next to them in the UI/UXtimer.text
dwyl/app-mvp-phoenix#102timer.end
totimer.stop
: #114upsert_people/1
function #115 tocreate
orupdate
aperson
record. https://github.com/dwyl/app-mvp/commit/c77d43af28fa3df04c2f711a37af0e1b31afc151DELETE
people
schema/table from the project! #118README.md