dwyl / mvp

📲 simplest version of the @dwyl app
https://mvp.fly.dev
GNU General Public License v2.0
84 stars 2 forks source link

EPIC: Update MVP App to Latest `Phoenix` with `auth_plug` #89

Closed nelsonic closed 2 years ago

nelsonic commented 2 years ago

This project is a bit out-of-date. Let's fix that and add @dependabot to keep it up-to-date!

Todo

nelsonic commented 2 years ago

@SimonLab the code is mostly there for the MVP. If you want to take a look at it now, please go for it. I've not had much focus time these last few days ... 🙄 really want to finish the README.md ... ⏳ If you want to change any part of the code, please go for it. I will reflect your updates in the README.md 📝 But please avoid any large refactors. we can put those in the "real" App. 💭

nelsonic commented 2 years ago

Minor detour: https://github.com/dwyl/app-mvp/issues/115 person being inserted multiple times! 🤦‍♂️

nelsonic commented 2 years ago

Do we need to have a people table in the MVP at all? 💭 >> https://github.com/dwyl/app-mvp/issues/118

nelsonic commented 2 years ago

Removing the people table as discussed/concluded in: https://github.com/dwyl/app-mvp/issues/118#issuecomment-1206248882

nelsonic commented 2 years ago

Successfully removes people schema/table from the project: https://github.com/dwyl/app-mvp/commit/316929c39888ea3285f6d42324844f95231f588e ✂️

New ERD:

image

Everything still works as expected. 📝 ⏳ ✅ That's it! The MVP in a nutshell. Two tables.

nelsonic commented 2 years ago

Coverage hasn't dropped, it's just not being accurately recorded on my Mac ... 🙄

image
nelsonic commented 2 years ago

@SimonLab I've finished updating the README.md: https://github.com/dwyl/app-mvp/blob/phoenix-1.6-2022-refresh-issue-%2389/README.md 📜 and BUILDIT.md dev log: https://github.com/dwyl/app-mvp/blob/phoenix-1.6-2022-refresh-issue-%2389/BUILDIT.md 🧑‍💻

Please take a look and give feedback when you can. 🙏 Thanks again for your patience on this. 👍

nelsonic commented 2 years ago

Final GIF: mvp-localhost-demo

nelsonic commented 2 years ago

After removing people table had to run:

ALTER TABLE items 
RENAME COLUMN status_code TO status;

DROP INDEX items_person_id_index;
ALTER TABLE items DROP CONSTRAINT items_person_id_fkey;

ALTER TABLE timers DROP CONSTRAINT timers_person_id_fkey;

DROP TABLE people;
nelsonic commented 2 years ago

@SimonLab your suggested fixes merged into the PR #90 ✅ Please review again when you can. 🙏

SimonLab commented 2 years ago

PR #90 merged, we can start the last checkbox item: iterate

nelsonic commented 2 years ago

Thanks again @SimonLab 🎉