dynamo-media / redmine_issue_detailed_tabs_time

30 stars 23 forks source link

Plugin breaks some Issues (500 error) #14

Open Bodge-IT opened 11 years ago

Bodge-IT commented 11 years ago

Hi, When I install this plugin(brilliant work by the way), It breaks some of my issues. they are only in the minority but I have not been able to figure out the difference between those that render OK and those that show Server Error 500.

Happy to provide access if you wanted to have a look?

I'm using it in redmine 2.3.2 with Timesheet and Time Tracker plugins, as well as RedmineCRM Helpdesk(pro) & Contacts light plugins.

The moment I uninstall the plugin, the Issues render again as they should. Any suggestions?

markedagain commented 11 years ago

give me a couple days and ill look into it with your combinations of addons. i already know the culprit i just need to figure out how to load my work in without taking over the entire template.

Bodge-IT commented 11 years ago

Brilliant…can’t tell you how much I like the plugin.

If you need anything from me, please let me know, happy to assist.

markedagain commented 11 years ago

hey @Bodge-IT i looked into the issue, im no expert, and ill keep checking for a solution, but the issue happens when 2 different plugins are trying to overwrite the same view file, in this case issues/_history.html.erb

my only dirty solution would be to see what plugin is causing your issue, and decide is the there history overwrite can be delete without loosing some function u want.

my only idea to fix the issue is changing all the server side code into a js that alters the look of the page after it renders and not overwrite on server side, but im not to crazy about doing this, as it will be alot of js, and i wont be able to implement my future permissions on tabs.

let me know if removing the view page from the other plugin is a possibility.

Bodge-IT commented 11 years ago

Hi, I'm using Redmine primarily for my automated helpdesk. The plugin I use for this is the RedmineCRM Helpdesk plugin which also requires the RedmineCRM contacts plugin. I couldn't do without either of these and I don't know if the view page could be done away with. Is there any way you could talk with Kiril? He's the dev at RedmineCRM, both of your plugins are excellent, so getting them to work together would be a real bonus.

thej4ck commented 10 years ago

@Bodge-IT i think i've discovered the cause of our issue. I've too the helpdesk plugin from redmineCRM.

Make this test: open the page of a issue with a anonymous journal update (any of the update automatically generated by the helpdesk email-crawler) and u will get a 500 error.

Open then a issue with no anonymous update and you will get a correct page display. isn't it?

i think that this is bounded to some piece of code that pretend to get teh login name of the Anonymous user that does not have it...

But i do not know ruby... sigh I think this is the same error of #35

Bodge-IT commented 10 years ago

I think you guys may be right. Helpdesk seems to be able to create a "user" and issue from emails. I use this part of Helpdesk a lot as part of automated system.

Any fix possible?

markedagain commented 10 years ago

very hard as i dont own helpdesk, im hopping a contributor that has it can help

markedagain commented 10 years ago

Ok, made a fix for anonymous users, can u see if this fixed this issue please. i dont have help desk so cant test

thej4ck commented 10 years ago

Thanks, i'll check tomorrow!

Nicola Mondinelli

Il giorno 09/dic/2013, alle ore 18:36, markedagain notifications@github.com ha scritto:

Ok, made a fix for anonymous users, can u see if this fixed this issue please. i dont have help desk so cant test

— Reply to this email directly or view it on GitHub.

markedagain commented 10 years ago

@Bodge-IT are you still using the plugin? We got a fix out for #35 and this might of fixed your issue as well

Bodge-IT commented 10 years ago

Thanks for letting me know markedagain…I’ve also been in touch with the dev of the conflicting plugin, he thinks he may have a fix in his next release.

I sure hope so, with these two working together things would get very cool!

I’ll install and let you know how it goes.

From: markedagain [mailto:notifications@github.com] Sent: 10 December 2013 15:23 To: markedagain/redmine_issue_detailed_tabs_time Cc: Gary Barclay Subject: Re: [redmine_issue_detailed_tabs_time] Plugin breaks some Issues (500 error) (#14)

@Bodge-IThttps://github.com/Bodge-IT are you still using the plugin? We got a fix out for #35https://github.com/markedagain/redmine_issue_detailed_tabs_time/issues/35 and this might of fixed your issue as well

— Reply to this email directly or view it on GitHubhttps://github.com/markedagain/redmine_issue_detailed_tabs_time/issues/14#issuecomment-30235998.

markedagain commented 10 years ago

Any luck on testing this ?