search

dynamo-media / redmine_issue_detailed_tabs_time

30 stars 24 forks source link

Clicking on a link to a note number does not behave as expected #30

Open ande3577 opened 10 years ago

ande3577 commented 10 years ago

Best demonstration of this. Click a bookmark for a time entry. Instead of jumping to that entry on the current tab, it will change to displaying all entries and time logs (while still showing the comments tab interestingly enough).

Near as I can tell, this is related to updating the url when clicking on a tab, as commenting out the following lines in issue-history-tabs.js::bind_tab() seems to fix it:

if("replaceState" in window.history){
  window.history.replaceState(null,document.title,'?tab='+tab);
}

It appears that when clicking on the note link, the current tab is discarded from the URL, which triggers a page reload instead of jumping to the anchor location on the current page.

markedagain commented 10 years ago

that is so odd. not sure why that bit of code is even running when we click the link. ill have to test it out, what browser are u using?

CodeInsider commented 10 years ago

Maybe I find some time today to take a quick look at it.

Am 30.08.2013 um 05:40 schrieb markedagain notifications@github.com:

that is so odd. not sure why that bit of code is even running when we click the link. ill have to test it out, what browser are u using?

— Reply to this email directly or view it on GitHub.

ande3577 commented 10 years ago

The browser is an up to date firefox. Haven't tested others.

willhbr commented 8 years ago

I came across this issue and submitted a fix for it