Closed salashnik closed 8 years ago
oh you simply commented out the lines. But this means if you change tabs you will never be able to reference a note# on a specific tab. I believe the better solution would be to ommit the default tab from url but keep the code there to make sure when tabs are switched that you can copy past the link to someone when talking about a comment or activity.
without these changes links to notes do not work at all (all links to notes rendered as http://redmine.url/issues/12345#note-5), even if they refer to messages on the default tab.
manually entered urls like http://redmine.url/issues/12345?tab=history_activity#note-7 also not works without commenting....
we lose only that pressing the "back" tab opens by default and not the last open
I'm sure there must be more elegant solution, but I do not see him ... It seems to me that disabling rewriting history somehow solves the problem described.
crap you are correct for the current note links not working, shows you how often im copy pasting does at office lol.
although when i tested out the second link it worked for me, it opened right tab and focused on the note itself ie /issues/1234?tab=history_activity#note-4
History override produce two problems: