dynamo-media / redmine_issue_detailed_tabs_time

30 stars 24 forks source link

Template::Error (undefined method `question' for #<Journal #9

Closed cforce closed 10 years ago

cforce commented 11 years ago

Error raises when rendering some issues (did not find out what exactly the cause is) or trying to save issues they could be rendred as not was trapped by the other bug before. Is the dependecy un questions plugin no hard coded? Because i test without this plugin at the moment. It should be optional or at least configurable.

ActionView::Template::Error (undefined method question' for #<Journal:0xd067680>): 21: for journal in journals 22: tabs.push({:label => :label_history_tab_comments, :name => 'history_comments'}) unless journal.notes.blank? 23: 24: if journal.question 25: 26: if journal.question.assigned_to == User.current || journal.user == User.current 27: #tabs.push({:label => :label_tabtime_my_questions, :name => 'tabtime_myquestions'} ) app/views/issues/show.html.erb:124:in_app_views_issues_show_html_erb___437952554_113424550' app/controllers/issues_controller.rb:119:in block (2 levels) in show' app/controllers/issues_controller.rb:116:inshow'

markedagain commented 11 years ago

Hey Terence, it’s an issue with the question support. Ill fix that in a couple hours

Mark Kalender

Software engineer

Real Vision LLC

From: Terence Miller [mailto:notifications@github.com] Sent: Tuesday, March 12, 2013 11:36 AM To: markedagain/redmine_issue_detailed_tabs_time Subject: [redmine_issue_detailed_tabs_time] Template::Error (undefined method `question' for #<Journal (#9)

Error raises when rendering some issues (did not find out what exactly the cause is)

ActionView::Template::Error (undefined method question' for #Journal:0xd067680): 21: for journal in journals 22: tabs.push({:label => :label_history_tab_comments, :name => 'history_comments'}) unless journal.notes.blank? 23: 24: if journal.question 25: 26: if journal.question.assigned_to == User.current || journal.user == User.current 27: #tabs.push({:label => :label_tabtime_my_questions, :name => 'tabtime_myquestions'} ) app/views/issues/show.html.erb:124:in_app_views_issues_show_html_erb___437952554_113424550' app/controllers/issues_controller.rb:119:in block (2 levels) in show' app/controllers/issues_controller.rb:116:inshow'

— Reply to this email directly or view it on GitHub https://github.com/markedagain/redmine_issue_detailed_tabs_time/issues/9 . https://github.com/notifications/beacon/MoM-1MHEPP7dLyDEKppe9EoN9khMy5AUHiF4Plq8iGGH0T3HZHZqXlZG-SUzh0tz.gif

markedagain commented 11 years ago

its very odd, ruby has a hard learning curve. for now i commented out the section i had added, ill try to figure out how to do proper plugin check and or method check before calling on these method. if u need it to work with questions just unccoment the lines in the the view template

jwalkerbg commented 11 years ago

I encountered this bug too. I'm not using question plugin

markedagain commented 11 years ago

yes, just pull new master, i removed the support for now