dynatrace-oss / OneAgent-SDK-Python-AutoInstrumentation

autodynatrace, a python library that implements automatic instrumentation using the OneAgent SDK for Python
Other
62 stars 29 forks source link

Bug - Double HTTP Request on Exception #13

Closed dlopes7 closed 4 years ago

dlopes7 commented 4 years ago

Bug in this line: https://github.com/dlopes7/autodynatrace/blob/9c8a9cc2bf8fa9bbd098dfa0fe4aefec85d44f9a/autodynatrace/wrappers/urllib3.py#L52 you make the HTTP request twice if an exception occurs during or after the HTTP request. Please also review similar try/except constructs.

dlopes7 commented 4 years ago

Fixed by #3