search

dynatrace-oss / api-client-python

Dynatrace API Python client
Apache License 2.0
60 stars 22 forks source link

Configuration v1/management zones #58

Closed mark-dt closed 2 years ago

mark-dt commented 2 years ago

Add functionality to pull and delete managenent zones from config v1

dynatrace-cla-bot commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: Dynatrace-James-Kitson
:x: Your Name

Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Dynatrace-James-Kitson commented 2 years ago

@dlopes7 A few design related decisions here, if you want to check if you agree with my thoughts.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

Dynatrace-James-Kitson commented 2 years ago

I moved those enums back to auto_tags but changed the management_zones one to make use of those as well. So they are only defined in one place but will 'live' in auto_tags. So if we ever need to we can make different versions for other endpoints as needed but can still reuse them and know where they are defined.