search

dynatrace-oss / api-client-python

Dynatrace API Python client
Apache License 2.0
60 stars 22 forks source link

Add missing types from RuleType #82

Closed mpmackenna closed 8 months ago

mpmackenna commented 8 months ago

The missing types cause a failure when calls are made to list the details of management zones that contain the corresponding types.

dynatrace-cla-bot commented 8 months ago

CLA assistant check
All committers have signed the CLA.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Dynatrace-James-Kitson commented 8 months ago

Disregarding the fact that it looks like these endpoints have been deprecated in favor of the settings API. It looks like the main issue was that the values allowed for the RuleType for auto tags is different from the set allowed for management zones. MZs have 32 allowed values whereas auto tags (where these were defined) allow only 18. Perhaps originally these were the same but they diverged.

Given how different they are I'm thinking it will better to have a RuleType defined specifically for MZs rather than to add these all to the auto tag one. I'll take a closer look if anything else needs to be changed.

Dynatrace-James-Kitson commented 8 months ago

Thanks @mpmackenna for identifying this issue. I noticed there's quite a difference between the 2 ruletypes so I created a new definition in the management zones file with the values specific to management zones.

This is published now in 1.1.63 so if you update you should have what you need.