Remove and optimize (hardcoded) LANS

[CaMer0n]

Remove all hard-coded terms from e107 and optimize!

Translator's Checklist:

• Remove any HTML from the LAN (bbcodes are okay)
• Use double-quotes. eg. define("LAN_01", "It's all good");
• Make sure "LAN" is used inside the constant name.
• Do not leave empty or unused defines. eg define("LAN_SOMETHING", ""); instead, comment them out with //
• Use $tp->lanVars() for variables conversion. eg. [x] etc.
• Check for duplicate/similar terms (admin only) against lan_admin.php (eg. LAN_UPDATE)
• Check for duplicate/similar terms (frontend or admin) against e107_languages/English/English.php
• Reduce the number of 'defines' as much as possible by using generic terms.
• Do NOT translate debug information. (eg. anything inside addDebug(); or "E107_DEBUG_LEVEL >0" etc. )
• Do NOT translate anything used within e_DEVELOPER.
• If you find a recurring word/term appearing in several areas of e107, please mention it here as a 'generic' candidate in this issue.

[MikeyGMT]

Looking at lans for updateadmin.php mostly duplicates. In fact why not send admin to usersettings? Seems like redundant code?

[tgtje]

Question how to proceed with these : see issue #2659
Explanation : on https://github.com/e107inc/e107/pull/2232/commits/2c68d9ee52eaf52bb80478420560bd5ef9269df6#diff-d7f2372327954fe64546996f2f909c95 (closed/merged pull request) on oldpolls php some LAN's were replace by new LAN's (LAN_FROM & LAN_TO new > were pollan_38; and 37 (being commented out). Some other new ones were added and put in admin/lan_admin php... Now LAN_FROM and LAN_TO (representing 'from' and 'to' were never incorporated.. Should these LAN"s (pollan 37;38) be reinstated to use (and oldpoll php be recoded OR the new LAN"s be added to the poll/English php (LAN_FROM & TO )and the coding left untouched ? Please some guidance here or advice how to....

[Moc]

@CaMer0n was this one closed intentionally?

[CaMer0n]

@Moc No. Looks like it came with the pull-request.