Modified asciidoctor build to avoid rendering chapters

[abelsromero]

This Pull Request includes:

• Updated Asciidoctor maven plugin and library to latest versions
• Removed imagesdir. Default value is good for the current setup
• Reorganized and formated pom.xml to follow common practices.
• Fixed attributes order in index. Asciidoctor accepts attributes above, but this is not correct.
• Renamed chapters to _chapters to avoid it from being rendered as individual documents. All directories and adoc files prefixed with _ are considered as hidden. This is handy in scenarios like this, where you want to split a long document in files that are included in a master file.

I went through the docs and there are some things you should consider:

• You are specifing the toc twice: once in the pom and on in the index document.
• You don't need to wrap urls with ++ to links unless they contain some special character.
• You can use standard comments for TODOs (i.e. // TODO do_something): they will show in the TODOs panel of most IDEs. In fact, the way you use, throws a warning line 49: invalid style for paragraph: TODO: Scope.
• Also, if you want to do something like "include all files in a directory", there are extensions to allow that.

Do not hesitate to ask me :+1:

[paulakeen]

Many many many thanks Abel!

[abelsromero]

Reviewed and all good!

But not merged? 😢

[paulakeen]

I eso k e lo q es?

Enviat des del meu telèfon intel·ligent Samsung Galaxy.

-------- Missatge original -------- De: Abel Salgado Romero notifications@github.com Data: 7/2/18 20:48 (GMT+01:00) A: eProcurement-everis/O3PO O3PO@noreply.github.com Ac: Enric Staromiejski Torregrosa Enric.Staromiejski.Torregrosa@everis.com, State change state_change@noreply.github.com Assumpte: Re: [eProcurement-everis/O3PO] Modified asciidoctor build to avoid rendering chapters (#4)

Reviewed and all good!

But not merged? 😢

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/eProcurement-everis/O3PO/pull/4#issuecomment-363888398, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APYwrP6YC_2a1mjYK7UQoOGzzRbRJfh2ks5tSf3TgaJpZM4R6uxG.

---

AVISO DE CONFIDENCIALIDAD. Este correo y la información contenida o adjunta al mismo es privada y confidencial y va dirigida exclusivamente a su destinatario. everis informa a quien pueda haber recibido este correo por error que contiene información confidencial cuyo uso, copia, reproducción o distribución está expresamente prohibida. Si no es Vd. el destinatario del mismo y recibe este correo por error, le rogamos lo ponga en conocimiento del emisor y proceda a su eliminación sin copiarlo, imprimirlo o utilizarlo de ningún modo.

CONFIDENTIALITY WARNING. This message and the information contained in or attached to it are private and confidential and intended exclusively for the addressee. everis informs to whom it may receive it in error that it contains privileged information and its use, copy, reproduction or distribution is prohibited. If you are not an intended recipient of this E-mail, please notify the sender, delete it and do not read, act upon, print, disclose, copy, retain or redistribute any portion of this E-mail.

---

CONFIDENTIALITY WARNING. This message and the information contained in or attached to it are private and confidential and intended exclusively for the addressee. everis informs to whom it may receive it in error that it contains privileged information and its use, copy, reproduction or distribution is prohibited. If you are not an intended recipient of this E-mail, please notify the sender, delete it and do not read, act upon, print, disclose, copy, retain or redistribute any portion of this E-mail.

[abelsromero]

It's when you accept the changes and include them in your repo.

[mfontsan]

@paulakeen I have reopened this pull request. Take into account that we MUST merge it into "Asciidoc_documentation" branch.

[paulakeen]

Happy now?