eProcurement-everis / ePO

2 stars 0 forks source link

Next steps: Improve design of Criteria #41

Open paulakeen opened 6 years ago

paulakeen commented 6 years ago

We should revisit the design of the Exclusion, Selection and Award Criterion sub-models- The current proposal is not "professional" from the design perspective:

Having three structures (sub-models) that are identical amongst themselves implies imposing a triple UNNECESSARY maintenance.

This is what is hapenning right now with the splitting of Criterion into Exclusion, Selection and Award Criterion. The solution to this is:

  1. Having one generic model that is business-agnostic named "Criterion", as we have now in the ePO CDM; (this is OK in the model);
  2. Having one domain-specific submodel named "Procurement Criterion" that extend the generic "Criterion" model with the inclusion of references to Lots.
  3. Having three classes that inherit from Procurement Criterion and per each one, have (or not) specific restrictions on the properties (e.g. onProperty "refersToLot" allow or not the linking to the Lot; e.g. in the case of the Exclusion Criteria references to Lots shall not be allowed).

To be discussed with you ASAP.