eXist-db / exist-stanford-nlp

XQuery wrapper around the Stanford CoreNLP pipeline
GNU Lesser General Public License v2.1
13 stars 6 forks source link

[question] ner-module location #5

Open duncdrum opened 4 years ago

duncdrum commented 4 years ago

see #4 the ner-module.xqm is located at /exist/etc/../data/expathrepo/stanford-nlp-0.5.8/content/ner-module.xqm shouldn't that be inside /db/system/repo instead?

lcahlander commented 4 years ago

Run it within the DB. It is accessible by just

import module namespace ner = "http://exist-db.org/xquery/stanford-nlp/ner";

There is no need for an at location, because it is registered.

duncdrum commented 4 years ago

exist finds it just fine, it's just a petty that i can't get to the functions during development. There is also a possibility that the app-archetype is doing something funky here.

adamretter commented 4 years ago

@duncdrum because the exist-stanford-nlp declares that it is an application and not a library (see https://github.com/lcahlander/exist-stanford-nlp/blob/master/xar-assembly.xml#L11) its files are all installed under /db/apps/stanford-nlp instead of /db/system/repo.

I think that /db/system/repo only holds the content of EXPath packages which are of type library.

For some reason a copy of the .xar file is left in /db/system/repo only when uploading via the Dashboard's Package Manager, I have opened a separate issue for that - https://github.com/eXist-db/existdb-packageservice/issues/13.

I think this is now resolved?

duncdrum commented 4 years ago

Dooh, although I think that speaks for splitting the package into a library and an application (with the front end stuff)

adamretter commented 4 years ago

@duncdrum Sure. Can we close this issue now?

duncdrum commented 4 years ago

@adamretter i ll close this after i had a go at refactoring the repo to contain separate library and app modules, either via PR or via giving up.