Fix changes to existing groups not being persisted

eamodio / SaveAllTheTabs

Quickly save and restore sets of document tabs in Visual Studio

MIT License

67 stars 30 forks source link

Fix changes to existing groups not being persisted #11

Closed toddsay closed 7 years ago

toddsay commented 7 years ago

When making changes to existing tab groups and then exiting Visual Studio, those changes do not persist and are lost. The issue is that replacing data within the collection does not trigger collection change events. This change forces that notification to occur so that the changes are saved.

eamodio commented 7 years ago

@toddsay I wasn't able to reproduce this issue (though I can kind of see where a problem could have happened). Can you try out this fix and make sure it resolves your issue?

toddsay commented 7 years ago

Thanks @eamodio! The solution in your commit looks good, and I can confirm that it is working for me.

To clarify my original description, my scenario was:

Change the set of open tabs by opening/closing code tabs
Click the SaveAllTheTabs save button
Exit Visual Studio
Run Visual Studio again, open the solution, and my changes weren't present

This problem no longer occurs. 👍

eamodio commented 7 years ago

@toddsay excellent -- thank you!