search

earlduque / Slack-Dark-Theme

A dark theme for Slack
97 stars 47 forks source link

Fix for slack 4.0.0 #36

Closed alinoancea closed 5 years ago

alinoancea commented 5 years ago

If someone can test this in other windows version, that would be great. I tested on Windows 10 x64.

Some feedback would be great :smile:

alinoancea commented 5 years ago

README.md should be changed accordingly (I'll try to do that later)

morbus commented 5 years ago

This has worked on two different machines for me.

  1. First, on a Windows 10 VM where I installed npm and ran the script.
  2. Second, I shared the revised app.asar with a coworker, who dropped it into place on their non-npm Win10 machine.
somanysteves commented 5 years ago

I got an error with it...

CMD /C "ASAR pack C:\Users\steve\AppData\Local\Temp\temp-15002\app C:\Users\steve\AppData\Local\Temp\temp-15002\app.asar"
C:\Users\steve\AppData\Roaming\npm\node_modules\asar\lib\asar.js:29
module.exports.createPackage = async function (src, dest) {
                                     ^^^^^^^^

SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\Users\steve\AppData\Roaming\npm\node_modules\asar\bin\asar.js:2:12)

Maybe a node versioning thing?

alinoancea commented 5 years ago

Hi @imjuststeve,

Can you tell me what version on Windows and node are you using?

somanysteves commented 5 years ago

@alinoancea Windows 10, node v6.17.1 :( I'd upgrade but I"m afraid to break our legacy builds

batjko commented 5 years ago

node v6.17.1 :(

Can you transpile from a higher version (i.e. using Babel)?

Jayhachi commented 5 years ago

I've tried running the Windows script on two different Win 10 x64 machines to no avail. one with Node 10.16.0 and the other with 12.6.0. I see "Dark theme installed...Please restart slack." although upon restarting am not seeing the desired results. I've noticed the modified date of app.asar has changed to the time of running the script as well. Is there something I'm missing here by chance?

alinoancea commented 5 years ago

What version of slack are you using? This method is not working on slack beta version 4.0.0

Jayhachi commented 5 years ago

I'm using Production 4.0.0 64-bit. I tried uninstalling and reinstalling before running the script again. It initially auto updated on both my machines and I didn't check version before uninstalling and reinstalling.

alinoancea commented 5 years ago

Can you reboot the machine after the script is completed, please? Maybe the slack doesn't know, for some reason, that the archive has changed.

maturner1 commented 5 years ago

The script runs just fine on my Win10 x64 with Node 12.6.0, however, upon restarting Slack, it just sits at the opening screen with a spinning wheel.

maturner1 commented 5 years ago

After re-installing Slack, this script works just fine.

alinoancea commented 5 years ago

Would you upload app.asar archive from C:\Users\<username>\AppData\Local\slack\app-[4.x.x]\resources so I can check it out? The infinite spinning wheel happened to me when the script was ran multiple times inserting the listener.js one after another in ssb-interop.bundle.js without checking if it's already there (that issue should be fixed tho)

maturner1 commented 5 years ago

Sorry, too late. My troubleshooting immediately kicked in when it didn't work and I went and did a fresh Slack install.

Jayhachi commented 5 years ago

Tried rebooting (actually shut down) and still no change. Tried uninstalling, deleting slack directory within C:\Users\username\AppData\Local and rebooting once more before installing again. I ran the script again, and reboot afterward.

alinoancea commented 5 years ago

Ok, can you please upload the app.asar archive from slack folder, after you run the script?

Jayhachi commented 5 years ago

app.asar attached. Apologies if there's something glaringly obvious that I failed to carry out successfully. app.zip

alinoancea commented 5 years ago

@Jayhachi, I downloaded your archive and replace mine on a clean Windows with a clean Slack installation. Everything is working fine. I will try some other things tomorrow and I'll keep you posted. Sorry for the inconvenience. :disappointed:

Jayhachi commented 5 years ago

@alinoancea I'm inconveniencing you I feel. Thanks for looking into it and I'll try the same on the other machine to see if I fare any better there when I get a chance.

alinoancea commented 5 years ago

Hi @Jayhachi, sorry for coming back so late, I'm got busy at work. Did you have time to take a look at your other machine? I can't think of another solution for the one that is not working, I'm sorry. If anyone has other thoughts about this and would like to share, it would be great.

jingofett commented 5 years ago

I don't think this is working with Slack 4.0.1 (I know it says for 4.0.0 but I thought I'd let you know) running on W10 x64, with Node JS 12.7

EDIT:

Nevermind, needed to reset the app by going to Help -> Troubleshooting -> Reset App as mentioned here: https://github.com/earlduque/Slack-Dark-Theme/issues/35#issuecomment-513420721

benjamhooper commented 5 years ago

If you're using windows use this in powershell (running in Administrator mode):

iex (new-object net.webclient).downloadstring('https://raw.githubusercontent.com/benjamhooper/slack-custom-theme/master/slackcustomtheme.ps1')

Run this for a custom slack theme, just use this repo's theme. The raw link: https://raw.githubusercontent.com/earlduque/Slack-Dark-Theme/master/dark.css

If you have issues, please visit here: https://github.com/benjamhooper/slack-custom-theme